Catch missing data #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take into account that $line_item['resourceId'] and $line_item['tag'] are optional
deep_link_settings['data'] might be empty. It is only required if present in LtiDeepLinkingRequest message: https://www.imsglobal.org/spec/lti-dl/v2p0#data
Use $request['target_link_uri'] as the fall-back redirect_uri.
Return new static instead of new LTI_Message_Launch so that the class can be extended. Throw exception when nonce does not check out. Remove var_dump() statement.
Return new static instead of new LTI_Deep_Link_Resource to make it easier to extend the class. Include all line_item attributes in new deep link resource, not just scoreMaximum and label.
Offer default for missing $lineitem["startDateTime"] and $lineitem["endDateTime"]. Return new static instead of new LTI_Lineitem to make it easier to extend the class. Decompose __toString() into two functions: to_array() and __toString()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes catch missing data, and make some classes more extendable.